Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make projects list searchable #4111

Merged
merged 1 commit into from
Aug 20, 2024
Merged

Make projects list searchable #4111

merged 1 commit into from
Aug 20, 2024

Conversation

kdid
Copy link
Contributor

@kdid kdid commented Aug 19, 2024

Summary

The project page only shows the last 100 projects. Though you can currently filter those results there is no way to find any other projects. We want the projects page to work similarly to the NUL Authorities Dashboard search where the search box actually searches all project rather than just filtering results.

Specific Changes in this PR

  • Update GraphQL API - add projectsSearch(query: String) query
  • Update UI to use new query when search term is entered.

Version bump required by the PR

See Semantic Versioning 2.0.0 for help discerning which is required.

  • Patch
  • Minor
  • Major

Steps to Test

  • From Meadow, click "Projects" on the top navigation bar (on dev will work best with prod snapshot DB)
  • Search for a project not shown in the initial result set
  • Please make sure other functionality works (add/edit/delete) as most of the functionality was refactored to work with the new searching.

🚀 Deployment Notes

Note - if you check any of these boxes go to the (always open) main <- staging PR and add detailed notes and instructions to help out others who may end up deploying your changes to production

  • Backward compatible API changes
    • Database Schema changes
    • GraphQL API
    • Elasticsearch API
    • Ingest Sheet
    • CSV metadata export/update API
    • Shared Links export API
  • Backwards-incompatible API changes
    • Database Schema changes
    • GraphQL API
    • Elasticsearch API
    • Ingest Sheet
    • CSV metadata export/update API
    • Shared Links export API
  • Requires data migration
  • Requires database triggers disabled during deployment/migration
  • Requires reindex
  • Terraform changes
    • Adds/requires new or changed Terraform variables
  • Pipeline configuration changes (requires mix meadow.pipeline.setup run)
  • Requires new variable added to miscellany
  • Specific deployment synchronization instructions with other apps/API's
  • Other specific instructions/tasks

Tested/Verified

  • End users/stakeholders

@kdid kdid force-pushed the 4352-projects branch 2 times, most recently from 364f418 to b1ad45a Compare August 20, 2024 20:42
Copy link
Contributor

@mbklein mbklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working great. Tested with data intended to trip up GraphQL (}, ", etc.) and it didn't flinch.

@kdid kdid merged commit 5f5ffa2 into deploy/staging Aug 20, 2024
4 checks passed
@kdid kdid deleted the 4352-projects branch August 20, 2024 21:15
@kdid kdid self-assigned this Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants